The benefit of a good economy would usually bode well for an incumbent. My father taught me that people voted their pocket books.
But that was before "identity politics," blacks, Hispanics, homosexuals, blue collar, white collar, and other assorted differences.